Skip to content

feat(snapshot::native): config root_path#4517

Merged
dmcgowan merged 2 commits intocontainerd:masterfrom
knight42:feat/native-config-root-path
Sep 3, 2020
Merged

feat(snapshot::native): config root_path#4517
dmcgowan merged 2 commits intocontainerd:masterfrom
knight42:feat/native-config-root-path

Conversation

@knight42
Copy link
Copy Markdown
Contributor

@knight42 knight42 commented Sep 1, 2020

Signed-off-by: knight42 anonymousknight96@gmail.com

Part of #4513 and #4514

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 1, 2020

Build succeeded.

@knight42 knight42 force-pushed the feat/native-config-root-path branch 2 times, most recently from 7ae1ebc to 33b269c Compare September 1, 2020 14:33
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 1, 2020

Build succeeded.

@knight42
Copy link
Copy Markdown
Contributor Author

knight42 commented Sep 1, 2020

/cc @AkihiroSuda

@AkihiroSuda
Copy link
Copy Markdown
Member

Looks good but please sign with the real name

@AkihiroSuda
Copy link
Copy Markdown
Member

Also please split commits for #4513 and #4514

@knight42 knight42 force-pushed the feat/native-config-root-path branch from 33b269c to b4af873 Compare September 3, 2020 11:37
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 3, 2020

Build succeeded.

Part of containerd#4514

Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
Part of containerd#4513

Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
@knight42 knight42 force-pushed the feat/native-config-root-path branch from b4af873 to c50ff69 Compare September 3, 2020 11:59
@knight42
Copy link
Copy Markdown
Contributor Author

knight42 commented Sep 3, 2020

@AkihiroSuda PTAL

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 3, 2020

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 445e26f into containerd:master Sep 3, 2020
@knight42 knight42 deleted the feat/native-config-root-path branch September 3, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants