Conversation
|
Hi @robberphex. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
60bda8d to
6ba4418
Compare
|
Build succeeded.
|
Signed-off-by: luyanbo <robert.lyb@alibaba-inc.com>
6ba4418 to
7a89bbe
Compare
AkihiroSuda
left a comment
There was a problem hiding this comment.
mTLS support is necessary for TCP.
Also, please explain the motivation of this.
Most APIs don’t work when the daemon and the client don’t share the same filesystem.
containerd/nerdctl#473 (comment)
|
Build succeeded.
|
|
See #1324 If you have an issue with an existing use case, please open an issue describing the problem and solutions can be discussed there. This is intentionally not allowed today, so closing this for now. Some higher level APIs such as CRI can support TCP today and we are looking to more higher level APIs which may be exposed via TCP. However, we do not plan to support the existing containerd APIs over TCP. |
In main branch, if caller pass address
tcp://1.1.1.1:8090toclient.New, will get err.In this PR, if caller pass
tcp://1.1.1.1:8090, the client will try to connect via tcp.