Skip to content

Client can connect via tcp#6393

Closed
robberphex wants to merge 1 commit intocontainerd:mainfrom
robberphex:for-remote-version-cmd
Closed

Client can connect via tcp#6393
robberphex wants to merge 1 commit intocontainerd:mainfrom
robberphex:for-remote-version-cmd

Conversation

@robberphex
Copy link
Copy Markdown

In main branch, if caller pass address tcp://1.1.1.1:8090 to client.New, will get err.

In this PR, if caller pass tcp://1.1.1.1:8090, the client will try to connect via tcp.

@k8s-ci-robot
Copy link
Copy Markdown

Hi @robberphex. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Dec 21, 2021

Build succeeded.

Signed-off-by: luyanbo <robert.lyb@alibaba-inc.com>
@robberphex robberphex force-pushed the for-remote-version-cmd branch from 6ba4418 to 7a89bbe Compare December 21, 2021 14:10
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mTLS support is necessary for TCP.
Also, please explain the motivation of this.
Most APIs don’t work when the daemon and the client don’t share the same filesystem.
containerd/nerdctl#473 (comment)

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Dec 21, 2021

Build succeeded.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Jan 3, 2022

See #1324

If you have an issue with an existing use case, please open an issue describing the problem and solutions can be discussed there. This is intentionally not allowed today, so closing this for now.

Some higher level APIs such as CRI can support TCP today and we are looking to more higher level APIs which may be exposed via TCP. However, we do not plan to support the existing containerd APIs over TCP.

@dmcgowan dmcgowan closed this Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants