Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Comments

Handle KVM based runtimes with selinux#1561

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:kata-se
Sep 1, 2020
Merged

Handle KVM based runtimes with selinux#1561
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:kata-se

Conversation

@crosbymichael
Copy link
Member

@crosbymichael crosbymichael commented Aug 27, 2020

This handles kvm based runtimes for new and old versions of the selinux packages. If the container_kvm_t label exists, then we use them, if not, we clear the process label.

Signed-off-by: Michael Crosby michael@thepasture.io

Signed-off-by: Michael Crosby <michael@thepasture.io>
@egernst
Copy link
Contributor

egernst commented Aug 27, 2020

Thanks @crosbymichael

Heads up @amshinde

@crosbymichael
Copy link
Member Author

/test pull-cri-containerd-node-e2e

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see question..

@k8s-ci-robot
Copy link

@crosbymichael: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cri-containerd-node-e2e d715d00 link /test pull-cri-containerd-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crosbymichael
Copy link
Member Author

Humm, weird error coming from e2e. I'll look into it, does not look related but who knows when you are dealing with selinux

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@egernst egernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@dims
Copy link
Member

dims commented Aug 29, 2020

LGTM

Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants