Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Comments

[release/1.3 backport] Make script work for both python2.7 and 3.6#1630

Merged
mikebrow merged 1 commit intocontainerd:release/1.3from
dims:thaJeztah-1.4_backport_python
Mar 9, 2021
Merged

[release/1.3 backport] Make script work for both python2.7 and 3.6#1630
mikebrow merged 1 commit intocontainerd:release/1.3from
dims:thaJeztah-1.4_backport_python

Conversation

@dims
Copy link
Member

@dims dims commented Mar 9, 2021

Signed-off-by: Varsha Teratipally teratipally@google.com
(cherry picked from commit bf3dcfe)
Signed-off-by: Sebastiaan van Stijn github@gone.nl

Signed-off-by: Varsha Teratipally <teratipally@google.com>
(cherry picked from commit bf3dcfe)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@adisky
Copy link
Contributor

adisky commented Mar 9, 2021

LGTM!!!

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims dims changed the title Make script work for both python2.7 and 3.6 [release/1.3 backport] Make script work for both python2.7 and 3.6 Mar 9, 2021
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
pull issues are a reported known issue with us not being on 1.6 golang in this release will have to move up soon.

Or not. Looks like Mr. @dims found a fix by disabling GO111MODULE support in prow.

@dims
Copy link
Member Author

dims commented Mar 9, 2021

/retest

1 similar comment
@dims
Copy link
Member Author

dims commented Mar 9, 2021

/retest

@mikebrow mikebrow merged commit c30c480 into containerd:release/1.3 Mar 9, 2021
else
# No python2 either by default, let's see if we can find python3
PYTHON="python3"
if ! command -v ${PYTHON} >/dev/null 2>&1; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using command -v is great!

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants