Decouple CreateCryptoConfig() from github.com/urfave/cli#56
Conversation
AkihiroSuda
force-pushed
the
split-create-crypto-config
branch
2 times, most recently
from
7cee4ee to
a6cfadb
Compare
|
@stefanberger @lumjjb PTAL, can we have a new release with this? |
|
LGTM. |
There was a problem hiding this comment.
EDIT: @AkihiroSuda I think we moved this function as part of ocicrypt, thoughts on calling it directly from ocicrypt library
https://github.com/containers/ocicrypt/blob/main/helpers/parse_helpers.go#L298
Iirc parse_helpers.go in the two projects were a bit different with imgcrypt's version supporting pgp/gpg better. |
The different part seems commented out https://github.com/containers/ocicrypt/blob/e4a936881fb7cf4b2b8fe49e81b8232fd4c48e97/helpers/parse_helpers.go#L234-L260 What was the reason to comment out this? |
|
I would let the unification of the parser_helpers happen independent of this PR... eventually it should happen. |
|
It i recall correctly, we commented it out in the |
| "github.com/urfave/cli" | ||
| ) | ||
|
|
||
| type Spec struct { |
There was a problem hiding this comment.
| type Spec struct { | |
| type EncArgs struct { |
minor nit, suggestion so that there is no confusion with the oci spec.
|
minor suggestion, lmk what you think, else we can merge it and create a new release |
AkihiroSuda
force-pushed
the
split-create-crypto-config
branch
from
a6cfadb to
1b763e7
Compare
Decouple `CreateCryptoConfig()` from `github.com/urfave/cli`, so that it can be called from other applications that do not use `github.com/urfave/cli`. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
split-create-crypto-config
branch
2 times, most recently
from
b00e927 to
fe5e256
Compare
|
Will tag as v1.1.2 then, ok? |
|
Pushed tag now. |
|
we should also be part of that tag to update it to ocicrypt 1.1.2 as well |
|
I deleted the v1.1.2 tag and by accident also the v1.1.1 tag. Can yo send a PR with the necessary ocicrypt updates? |
3 participants
Decouple
CreateCryptoConfig()fromgithub.com/urfave/cli, so that it can be called from other applications that do not usegithub.com/urfave/cli.