Skip to content

Comments

ci: update golangci-lint to v2.1.6#5

Merged
estesp merged 1 commit intocontainerd:mainfrom
austinvazquez:update-golangci-lint
Dec 5, 2025
Merged

ci: update golangci-lint to v2.1.6#5
estesp merged 1 commit intocontainerd:mainfrom
austinvazquez:update-golangci-lint

Conversation

@austinvazquez
Copy link
Member

@austinvazquez austinvazquez commented Jun 4, 2025

This change updates golangci-lint to v2.1.6.

For the configuration updates, I ran golangci-lint migrate and added back a few linters that had been removed by default.

@austinvazquez
Copy link
Member Author

Needs #6

@austinvazquez austinvazquez requested a review from Copilot June 4, 2025 16:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project’s golangci-lint version to v2.1.6 and updates both the lint configuration file and CI workflow to match the new release.

  • Migrate .golangci.yml to v2.1.6 format, re-enable select linters, and add new exclusions and formatters sections
  • Bump the GitHub Actions step to install golangci-lint v2.1.6 and update the action reference accordingly

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.golangci.yml Migrated config to v2 schema, updated enabled linters, added exclusions and formatting config
.github/workflows/ci.yml Changed action to golangci-lint-action@v8 and set version: v2.1.6
Comments suppressed due to low confidence (3)

.github/workflows/ci.yml:41

  • The GitHub Action reference golangci/golangci-lint-action@v8 may not exist; please verify the supported major version (for example, v6 or v4) and update the tag accordingly.
-      - uses: golangci/golangci-lint-action@v8

.golangci.yml:17

  • Consider reintroducing a run: timeout: 5m setting in the root of this config so that local golangci-lint runs use the same timeout without relying solely on the CI flags.
exclusions:

.golangci.yml:47

  • Indentation for the - test entry under formatters.exclusions.paths is inconsistent with the other path entries and may cause a YAML parse error; align it with the rest.
      - test

Signed-off-by: Austin Vazquez <austin.vazquez.dev@gmail.com>
@austinvazquez austinvazquez force-pushed the update-golangci-lint branch from 367c096 to 0d79777 Compare June 4, 2025 19:55
@austinvazquez austinvazquez marked this pull request as ready for review June 4, 2025 19:56
@estesp estesp merged commit f613eea into containerd:main Dec 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants