Use new shim bootstrap protocol#155
Merged
akerouanton merged 1 commit intocontainerd:mainfrom Apr 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates nerdbox’s containerd shim integration to the newer bootstrap protocol and bumps related dependencies/tooling to match the updated containerd APIs.
Changes:
- Switch shim entrypoint to
shim.RunShim(...)and updateNewShimManagerto return the newshim.Shiminterface. - Migrate shim manager
Startimplementations (unix/windows) to the new bootstrap API request/response types. - Update Go module dependencies (containerd/api, hcsshim/go-winio, otel, x/*, etc.) and Go version directive.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/shim/manager/manager.go | Updates NewShimManager to return shim.Shim (new shim bootstrap integration). |
| internal/shim/manager/manager_unix.go | Ports Start to bootapi.BootstrapParams/BootstrapResult and socket-dir sourcing via bootstrap params. |
| internal/shim/manager/manager_windows.go | Ports Start to new bootstrap API and adds named-pipe readiness polling before returning address. |
| cmd/containerd-shim-nerdbox-v1/main.go | Switches shim entrypoint from Run to RunShim to match updated shim framework. |
| go.mod | Updates Go version directive and dependency versions/replacements to align with new containerd bootstrap protocol. |
| go.sum | Refreshes dependency checksums for the updated module graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dmcgowan
force-pushed
the
update-containerd-latest-dev
branch
from
0cb32ca to
9a2142b
Compare
dmcgowan
force-pushed
the
update-containerd-latest-dev
branch
from
9a2142b to
1f37560
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update containerd version and use the new bootstrap protocol. Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
update-containerd-latest-dev
branch
from
1f37560 to
ea581d1
Compare
akerouanton
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update containerd version and use the new bootstrap protocol.