logging: ensure that MagicArgv1 is always argv1 #1055
Conversation
Signed-off-by: Zheao.Li <me@manjusaka.me>
Zheaoli
force-pushed
the
manjusaka/fix-1054
branch
from
8f86f2d to
32e8e3c
Compare
| query.Set("aa", "2") | ||
| result := query.Encode() | ||
| assert.Equal(t, result, "abc=1&aa=2", "") | ||
| } |
There was a problem hiding this comment.
Sorry, this is not correct, as the ordering is ignored on parsing back the string to *net.URL
There was a problem hiding this comment.
May I ask if it is correct if we sort the args when in the nerdctl xmain function?
There was a problem hiding this comment.
BTW, we have a fallback here https://github.com/containerd/nerdctl/blob/master/cmd/nerdctl/main.go#L75-L80 to help us ignore the args order. Maybe we don't need to concern about the args order?
There was a problem hiding this comment.
May I ask if it is correct if we sort the args when in the nerdctl xmain function?
No, that doesn't work with nerdctl run busybox echo "_NERDCTL_INTERNAL_LOGGING"
Maybe we don't need to concern about the args order?
Need
|
Opened an alternative PR #1056 |
2 participants
fix: #1054
Signed-off-by: Zheao.Li me@manjusaka.me