logging: ensure that MagicArgv1 is always argv1 #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Fix issue 1054 Replace PR 1055 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
junnplus
reviewed
May 12, 2022
| return nil, err | ||
| } | ||
| args := map[string]string{ | ||
| logging.MagicArgv1: dataStore, |
Member
There was a problem hiding this comment.
An immature idea, why not consider splicing the parameters behind the dataStore, like
binary:///usr/local/bin/nerdctl?_NERDCTL_INTERNAL_LOGGING=/var/lib/nerdctl/1935db59\?maxSize=1
Member
Author
There was a problem hiding this comment.
Just didn't want to invent a new microformat
Member
There was a problem hiding this comment.
Or put args in the labels of the container? like nerdctl/logging.driver / nerdctl/logging.max-file
To be honest, I am not inclined to store some information by adding new files. :(
Member
Author
There was a problem hiding this comment.
How can we let the log binary access the labels?
ktock
approved these changes
May 12, 2022
fahedouch
approved these changes
May 12, 2022
Member
|
@AkihiroSuda would you plz merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1054
Replace #1055
The opts are now stored in
filepath.Join(dataStore, "containers", ns, id, "log-config.json")