-
Notifications
You must be signed in to change notification settings - Fork 711
Refactor: cleanup XDGRuntime #3850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b1c9415 to
890d40e
Compare
|
Was wondering if we should even incorporate into but (for now) elected for pure refactoring with no change of behavior. |
|
Not clear why the failures (some of it is definitely the usual stargz / layer not found), but the rest is weird (eg: platform timeout). If we can poke it in case it is a fluke... |
890d40e to
a769865
Compare
|
CI failure seems to be a timeout. |
116f492 to
57046a1
Compare
|
Failures are a bunch of timeouts. Looks like the import cache manifest from github cache are extremely slow during the initial build phase:
Wether we should increase the overall timeout over 30 minutes or not is something we can talk about - at least these type of events would not fail the builds - but the underlying issue seem to be github action cache. |
57046a1 to
58515b1
Compare
|
Rebasing to force CI re-run. |
| run = fmt.Sprintf("/run/user/%d", rootlessutil.ParentEUID()) | ||
| if rootlessutil.IsRootlessChild() { | ||
| return "", err | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warn should be still printed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is necessary, since err will be bubbled up and printed out as an error anyhow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eg: if we leave the warn, we will just print the error twice (once as a warn, and then as an error)
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
58515b1 to
3b59119
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
CI failure looks like #3556 I am not sure why we are suddenly hitting that one a lot more. Did we recently change something wrt cni? |
From reading code, it seems to me like:
XDGRuntimeDir()should check the value ofROOTLESSKIT_PARENT_EUID(likeParentEUIDdoes)getXDGRuntimeDir()in bypass4netns is essentially duplicatingXDGRuntimeDir()getRuntimeVariableDataDirandCNIRuntimeDirshould not ignore errors, and they seem to have faulty logic (relying onGeteuidregardless of conditions), or callingrootlessutil.ParentEUIDwhich will redo stuff done already inXDGRuntimeDir()PR addresses these.