Fix TestImageConvert/soci* tests for v0.12.0 release #4623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henry118
force-pushed
the
fix-soci-test
branch
4 times, most recently
from
7150669 to
a3d68f4
Compare
AkihiroSuda
reviewed
Nov 27, 2025
pkg/snapshotterutil/sociutil.go
Outdated
|
|
||
| sociCmd.Args = append(sociCmd.Args, "convert") | ||
|
|
||
| // The following option temporarily fix the image conversion issue in 0.12.0 |
Member
There was a problem hiding this comment.
Could you put the issue URL in the comment
Signed-off-by: Henry Wang <henwang@amazon.com>
henry118
force-pushed
the
fix-soci-test
branch
from
a3d68f4 to
accc2f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4622
Temporarily fix the soci image conversion regression introduced in soci v0.12.0 release.
It looks like proper fix would require a soci code change.
This patch simply fix the nerdctl canary.