fix: sort results of nerdctl ps and nerdctl compose ps alphabetic…
#4628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally The current implementation can cause the unit test for `FormatPorts` in `pkg/formatter` to fail intermittently, as shown below: ```bash $ go test -run TestFormatPorts -count 10 --- FAIL: TestFormatPorts (0.00s) --- FAIL: TestFormatPorts/mixed_tcp_and_udp_with_consecutive_ports_on_anyhost (0.00s) formatter_test.go:191: assertion failed: 0.0.0.0:3000-3001->8080-8081/tcp, 0.0.0.0:3002-3003->8082-8083/udp (tt.expected string) != 0.0.0.0:3002-3003->8082-8083/udp, 0.0.0.0:3000-3001->8080-8081/tcp (result string) --- FAIL: TestFormatPorts (0.00s) --- FAIL: TestFormatPorts/mixed_tcp_and_udp_with_consecutive_ports_on_anyhost (0.00s) formatter_test.go:191: assertion failed: 0.0.0.0:3000-3001->8080-8081/tcp, 0.0.0.0:3002-3003->8082-8083/udp (tt.expected string) != 0.0.0.0:3002-3003->8082-8083/udp, 0.0.0.0:3000-3001->8080-8081/tcp (result string) --- FAIL: TestFormatPorts (0.00s) --- FAIL: TestFormatPorts/mixed_tcp_and_udp_with_consecutive_ports_on_anyhost (0.00s) formatter_test.go:191: assertion failed: 0.0.0.0:3000-3001->8080-8081/tcp, 0.0.0.0:3002-3003->8082-8083/udp (tt.expected string) != 0.0.0.0:3002-3003->8082-8083/udp, 0.0.0.0:3000-3001->8080-8081/tcp (result string) FAIL exit status 1 FAIL github.com/containerd/nerdctl/v2/pkg/formatter 0.005s ``` This occurs because the `FormatPorts` function iterates over a map, whose iteration order is non-deterministic. As a result, the output string may vary between test runs. This behavior has been reported in issue/containerd#4626. To address this, this commit ensures that the string returned by `FormatPorts` is sorted alphabetically, resulting in stable and predictable output. Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ally
The current implementation can cause the unit test for
FormatPortsinpkg/formatterto fail intermittently, as shown below:This occurs because the
FormatPortsfunction iterates over a map, whose iteration order is non-deterministic.As a result, the output string may vary between test runs.
This behavior has been reported in issue/#4626.
To address this, this commit ensures that the string returned by
FormatPortsis sorted alphabetically, resulting in stable and predictable output.