fix: Add retry for systemd to startup before running exec#4778
Open
Shubhranshu153 wants to merge 1 commit intocontainerd:mainfrom
Open
fix: Add retry for systemd to startup before running exec#4778Shubhranshu153 wants to merge 1 commit intocontainerd:mainfrom
Shubhranshu153 wants to merge 1 commit intocontainerd:mainfrom
Conversation
Shubhranshu153
changed the title
AkihiroSuda
reviewed
Mar 9, 2026
Member
There was a problem hiding this comment.
Thanks, but still flaky
https://github.com/containerd/nerdctl/actions/runs/22777960578/job/66076770568?pr=4778
=== Failing tests ===
TestLogs
TestLogs/since_60s
TestLogs/until_60s
TestRunWithSystemdTrueEnabled
Contributor
Author
There was a problem hiding this comment.
hmm, for logs i will have separate one.
TestRunWithSystemdTrueEnabled -> this one i will look more thoroughly. Locally its hard to reproduce.
Shubhranshu153
force-pushed
the
fix-systemd-test
branch
from
d1992e7 to
4d2f926
Compare
Contributor
Author
|
The retry logic itself is working. Increased the time between retries to check if its just a slow process. |
Shubhranshu153
force-pushed
the
fix-systemd-test
branch
2 times, most recently
from
fdb76c7 to
2b234de
Compare
Signed-off-by: Shubhranshu Mahapatra <shubhum@amazon.com>
Shubhranshu153
force-pushed
the
fix-systemd-test
branch
from
2b234de to
479ea02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4746
Added a retry logic to allow sometime for systemd to start.