Skip to content

ci: add zizmor workflow linting#4909

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
omribz156:codex/add-zizmor
May 21, 2026
Merged

ci: add zizmor workflow linting#4909
AkihiroSuda merged 1 commit into
containerd:mainfrom
omribz156:codex/add-zizmor

Conversation

@omribz156
Copy link
Copy Markdown
Contributor

Summary:

  • Add zizmor to the workflow lint CI.
  • Fix the workflow findings reported by zizmor, including token persistence, excessive permissions, setup-go caching, and template-injection warnings.

Verification:

  • uvx zizmor .github/workflows
  • C:\Users\omrib\go\bin\actionlint.exe -ignore 'not assignable' -ignore 'property "hack" is not defined'
  • git diff --check

Note: raw actionlint reports the same existing baseline findings on clean origin/main and this branch. With those baseline findings ignored, this branch does not add new actionlint findings.

This was implemented with Codex assistance, with the final diff reviewed before posting.

Comment thread .github/workflows/workflow-lint.yml Outdated
uses: zizmorcore/zizmor-action@b1d7e1fb5de872772f31590499237e7cce841e8e # v0.5.3
with:
inputs: .github/workflows
# Do not send workflow diagnostics to GHAS in this project right now.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is GHAS

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded this to GitHub Advanced Security code scanning in the comment so the acronym is not floating around unexplained.

@AkihiroSuda
Copy link
Copy Markdown
Member

Please squash the commits, then LGTM

Signed-off-by: Omri SirComp <omribz156@gmail.com>
@omribz156
Copy link
Copy Markdown
Contributor Author

Thanks, squashed into one signed-off commit and force-pushed.

@AkihiroSuda AkihiroSuda added this to the v2.3.1 milestone May 20, 2026
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 00476a1 into containerd:main May 21, 2026
73 of 80 checks passed
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label May 21, 2026
@AkihiroSuda AkihiroSuda linked an issue May 21, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: add zizmor (GHA linter)

2 participants