Add check of snapshotter when sharing images #936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Mar 25, 2022
cmd/nerdctl/build.go
Outdated
| return false, nil | ||
| } | ||
| return executor == "containerd" && containerdUUID == uuid && containerdNamespace == namespace, nil | ||
| containerdSnapshotter, ok := labels["org.mobyproject.buildkit.worker.snapshotter"] |
Member
There was a problem hiding this comment.
Suggested change
| containerdSnapshotter, ok := labels["org.mobyproject.buildkit.worker.snapshotter"] | |
| workerSnapshotter, ok := labels["org.mobyproject.buildkit.worker.snapshotter"] |
ktock
force-pushed
the
build-ensure-snapshotter
branch
from
1105aa7 to
e746268
Compare
AkihiroSuda
reviewed
Mar 25, 2022
cmd/nerdctl/build.go
Outdated
| return false, nil | ||
| } | ||
| containerdUUID, ok := labels["org.mobyproject.buildkit.worker.containerd.uuid"] | ||
| workerUUID, ok := labels["org.mobyproject.buildkit.worker.containerd.uuid"] |
Member
There was a problem hiding this comment.
This should be still containerdUUID because it is under o.m.b.w.containerd.
OTOH, workerSnapshotter shouldn't be containerdSnapshotter because it is not under o.m.b.w.containerd.
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
ktock
force-pushed
the
build-ensure-snapshotter
branch
from
e746268 to
50cbdfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #858 (review)