Add error status in ZFile::BlockReader#230
Merged
liulanzheng merged 1 commit intocontainerd:mainfrom Jun 19, 2023
Merged
Conversation
BigVan
force-pushed
the
zfile_br_eno
branch
2 times, most recently
from
6b47f18 to
e1fe2b1
Compare
yuchen0cc
reviewed
Jun 16, 2023
| } | ||
| m_reader->m_begin_idx = m_reader->m_idx; | ||
| } | ||
| get_current_block(); |
Contributor
There was a problem hiding this comment.
goto end if not return 0 ?
Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add return value check for Zfile::BlockReader to avoid getting invalid data in ZFile::pread.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: