Allow overriding the previous commit for a dependency#43
Merged
mxpv merged 2 commits intocontainerd:mainfrom Oct 11, 2023
Merged
Allow overriding the previous commit for a dependency#43mxpv merged 2 commits intocontainerd:mainfrom
mxpv merged 2 commits intocontainerd:mainfrom
Conversation
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
samuelkarp
approved these changes
Oct 9, 2023
mxpv
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be able to handle when a library is split out into an external dependency. Currently that dependency will show up with all its commits seen as new for inclusion. The dependency overrides lets us choose the previous commit to use for the release to only include commits since then.