Annotate some variables as sometimes-unused#486
Merged
smcv merged 2 commits intocontainers:mainfrom May 11, 2022
Merged
Conversation
This variable is only used for lifetime tracking (autocleanup), but clang warns on that. Signed-off-by: Simon McVittie <smcv@collabora.com>
…bled These parameters are unused if SELinux happens to be disabled. Signed-off-by: Simon McVittie <smcv@collabora.com>
Collaborator
Author
|
@RyuzakiKK, perhaps you could do some not-a-maintainer review here? The changes are trivial. |
Contributor
|
LGTM |
Collaborator
Author
|
This is sufficiently trivial that I''ve landed it based on @RyuzakiKK's positive review. Having bubblewrap be warnings-clean is helpful when it's included in a larger project as a submodule. Please revert if you disagree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silence -Wunused-but-set-variable with clang
This variable is only used for lifetime tracking (autocleanup), but
clang warns on that.
utils: Silence -Wunused-parameter with clang, Meson, and SELinux disabled
These parameters are unused if SELinux happens to be disabled.
The second commit fixes some non-fatal warnings seen on #478, and the first fixes a related warning seen when I tried to test this.