Typos and doc fixes#749
Merged
smcv merged 5 commits intocontainers:mainfrom May 5, 2026
Merged
Conversation
Fix a typo introduced when rewording the documentation in commit d9f35ab ("README: Update the user namespace / setuid section", 2026-04-14) Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
The 'u' in "unprivileged" really sounds like a vowel, so use "an". Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
This also removes a typo: "an process". Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
Adjust wording in one of the comment, to read more clearly. Consider the previous wording: "... a problem if we're privileged, if we're not opt_unshare_user ..." it might sound like the "not" refers to `opt_unshare_user`, while in fact refers to "being privileged" from the previous sentence. Adding a "then" removes the ambiguity, making the message flow better, especially for non-native English readers. Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
Use more correct wording in some die() messages. While at it remove a double space in one of the messages. Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
Contributor
Author
|
cc @smcv |
smcv
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
while getting familiar with the bubblewrap code I ran into some typos and possible improvements to the docs.
Here are some changes to address those.
Thanks, Antonio