Fix dangling filter for images command

[TomSweeneyRedHat]

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

In version 1.4 of Buildah and earlier, the internal name for a dangling image was <none>. With changes that came in after 1.4, the internal name was changed to <none>:<none> and this caused the buildah images --filter dangling=true command to no longer work.

Rather than comparing strictly to <none>, this change does a strings.contains() for that. I've also added tests so if we fall off the rails again in the future, the test system will catch it.

Addresses: #1199
Tests:

# ctr=$(buildah from scratch)

# buildah commit $ctr test
{output removed for brevity}
Storing signatures
1ace9c1b7814267c30e6377b900dbfaacdba9aee6adb692f3d140e20d0e19d30

# buildah commit $ctr test
{output removed for brevity}
Storing signatures
2d9f02d2fb65ba3a9ca4e70ec158892183427aecfe30b8e9e15d8153d20222ba

# buildah images
IMAGE NAME                                               IMAGE TAG            IMAGE ID             CREATED AT             SIZE
<none>                                                   <none>               1ace9c1b7814         Nov 27, 2018 08:56     1.63 KB
localhost/test                                           latest               2d9f02d2fb65         Nov 27, 2018 08:56     1.63 KB

# buildah images --filter dangling=false
IMAGE NAME                                               IMAGE TAG            IMAGE ID             CREATED AT             SIZE
localhost/test                                           latest               2d9f02d2fb65         Nov 27, 2018 08:56     1.63 KB

# buildah images --filter dangling=true
IMAGE NAME                                               IMAGE TAG            IMAGE ID             CREATED AT             SIZE
<none>                                                   <none>               1ace9c1b7814         Nov 27, 2018 08:56     1.63 KB

[rhatdan]

LGTM

[rhatdan]

Looks like your tests are failing.

[TomSweeneyRedHat]

@rhatdan yeah, they passed locally in my sandbox, trying to figure out what's different in Travis CI.

[rhatdan]

bot, retest this please
@giuseppe @umohnani8 @vrothberg @pixdrift @nalind @boaz1337 PTAL

[TomSweeneyRedHat]

bot, retest this please.

[umohnani8]

LGTM
Question: Would intermediate images that are built during a build process also be considered as dangling images? Intermediate images have <none> as their name.

[TomSweeneyRedHat]

I'm going to close and then reopen in hopes that will get Red Hat CI hip.

[TomSweeneyRedHat]

@rhatdan Red Hat CI keeps crashing without any bread crumbs. @jlebon do you know of anything going sideways there? It was working earlier today, I think before noon, but not since.

[rhatdan]

@rh-atomic-bot r+

[rh-atomic-bot]

📌 Commit aaac18e has been approved by rhatdan

[rh-atomic-bot]

⌛ Testing commit aaac18e with merge 620fdee...

[rh-atomic-bot]

☀️ Test successful - status-papr, status-travis
Approved by: rhatdan
Pushing 620fdee to master...

[TomSweeneyRedHat]

@umohnani8 I believe the intermediate images that you're describing, if tagged as ":" are also considered to be dangling. But I'd take @nalind 's or @rhatdan 's word on that over mine.

[rhatdan]

I would have to check if Docker considers them dangling. That would be the standard I guess.