Skip to content

Fix call to chown#6683

Merged
giuseppe merged 2 commits intocontainers:mainfrom
stilwelb:fix-chown
Feb 11, 2026
Merged

Fix call to chown#6683
giuseppe merged 2 commits intocontainers:mainfrom
stilwelb:fix-chown

Conversation

@stilwelb
Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes #6682 by correcting the call to chown to pass the gid instead of a uid.

How to verify it

Which issue(s) this PR fixes:

Fixes #6682

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Signed-off-by: Brad Stilwell <stilwelb@us.ibm.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 10, 2026
@nalind nalind added the No New Tests Allow PR to proceed without adding regression tests label Feb 10, 2026
@nalind
Copy link
Copy Markdown
Member

nalind commented Feb 10, 2026

Affects release-1.41, release-1.42, release-1.43.

Copy link
Copy Markdown
Member

@nalind nalind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: there's a similar mistake at line 2332, which can either be fixed here or in a follow-up PR. LGTM either way. Thanks!

Signed-off-by: Brad Stilwell <stilwelb@us.ibm.com>
@stilwelb
Copy link
Copy Markdown
Contributor Author

Non-blocking: there's a similar mistake at line 2332, which can either be fixed here or in a follow-up PR. LGTM either way. Thanks!

Good catch! I pushed another commit to address it since they are related.

@packit-as-a-service
Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

@stilwelb stilwelb requested a review from nalind February 10, 2026 16:36
Copy link
Copy Markdown
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This ideally should have simple unit tests, but I am not sure if the cost of testing typos is worth it.

Copy link
Copy Markdown
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@giuseppe giuseppe merged commit 480927c into containers:main Feb 11, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No New Tests Allow PR to proceed without adding regression tests size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chown in copier.go passes uid for both uid/gid

4 participants