imagebuildah.stageExecutor.Run(): pull images for transient mounts#6690
Merged
Conversation
When we're passed a TransientRunMount specification that references an image by name, be ready to pull the image. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
dosubot
Bot
added
the
size:S
nalind
added
the
jira
Member
|
LGTM I restarted the failed test. I'm 95% sure it's a flake, but we'll see. |
Member
|
@lsm5 PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When
buildah buildis passed a--mountoption that references an image in its "from" value, instead of pulling the image, as we do when the--mountoption is included in the Dockerfile, we would return an error. Correct the difference in behavior.How to verify it
New integration test!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
This does nothing for a similar error when
buildah runis given a--mountflag which references an image which hasn't been pulled. I'm not sure about that.Does this PR introduce a user-facing change?