Ignore .containerignore for git repositories in ADD

[simonbrauner]

What type of PR is this?

/kind api-change

/kind bug

/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Fixes: #6614

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Local `.containerignore` is no longer applied to ADD from git repositories.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[Honny1]

LGTM, once @TomSweeneyRedHat 's comment is addressed.

[nalind]

The stageExecutor.performCopy() method sets the "Excludes" field in the options and passes the list of sources to the Add() method. Can't it base the "Excludes" value it passes in on whether or not a source value it's also passing in is a git location?

If need be, the sourceIsGit() helper function could be moved from add.go to an internal package so that performCopy() could call it. There's a check early on in define.TempDirForURL() that could probably stand to use it, too.

[nalind]

Could the test -f that's being done below be done as a RUN instruction during the build?

[simonbrauner]

Yes, it could, and it is simpler that way. Fixed.

[simonbrauner]

@nalind thanks for the review

The stageExecutor.performCopy() method sets the "Excludes" field in the options and passes the list of sources to the Add() method. Can't it base the "Excludes" value it passes in on whether or not a source value it's also passing in is a git location?

If need be, the sourceIsGit() helper function could be moved from add.go to an internal package so that performCopy() could call it. There's a check early on in define.TempDirForURL() that could probably stand to use it, too.

Can you elaborate on this? If I understand this correctly, the idea is to set excludes correctly based on what the source is instead of having two - excludes and gitExcludes, and deciding which one is used later. I am fine with moving sourceIsGit elsewhere so that I can use it in the function that calls Add(), but I am not sure how to use sourceIsGit afterwards.

Because with my understanding:

The Add() method goes through all the sources at once, so there could be both git and non-git sources, so I cannot have one excludes.

Unless:

1. I call Add() for each source separately. Which seems like a strange idea, given that Add() is implemented to handle all the sources at once.
2. I call Add() twice; once for git sources and once for non-git sources. Which could be problematic when ordering matters in case there is ADD local git local git /mount-dir.

[nalind]

2. I call `Add()` twice; once for git sources and once for non-git sources. Which could be problematic when ordering matters in case there is `ADD local git local git /mount-dir`.

That's what we more or less already do when heredocs are also in the mix, so that wouldn't be a new problem.