copier: Fix some log messages#6808
Merged
TomSweeneyRedHat merged 1 commit intoApr 23, 2026
Merged
Conversation
dosubot
Bot
added
the
size:XS
Contributor
Author
|
@containers/buildah-maintainers, I don't think I can easily write tests for those/that its worth having tests |
giuseppe
added
the
No New Tests
giuseppe
reviewed
Apr 22, 2026
| hostFilePair, err := idMappings.ToHost(containerFilePair) | ||
| if err != nil { | ||
| return errorResponse("copier: put: error mapping container filesystem owner %d:%d to host filesystem owners: %v", fileUID, fileGID, err) | ||
| return errorResponse("copier: put: error mapping container filesystem owner %d:%d to host filesystem owners: %v", &fileUID, &fileGID, err) |
Member
There was a problem hiding this comment.
this needs to be *fileUID and *fileGID
Contributor
Author
There was a problem hiding this comment.
woops, good catch.. Fixed
- The error when checking if directory is an absolute path doesn't log the right directory - The incorrect size read inverted the read vs expected bytes - The fileUID and fileGID logs logged the pointer to the values instead of the values themselves Signed-off-by: Benjamin Schubert <bschubert15@bloomberg.net>
BenjaminSchubert
force-pushed
the
bschubert/log-fixes
branch
from
dbe1617 to
d765fd9
Compare
Member
|
LGTM, thanks! |
Member
|
LGTM |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
How to verify it
N/A
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?