Skip to content

copier.TestTarPut(): test both with and without chroot#6856

Merged
TomSweeneyRedHat merged 1 commit into
containers:mainfrom
nalind:copier-testtarput-chroot
May 22, 2026
Merged

copier.TestTarPut(): test both with and without chroot#6856
TomSweeneyRedHat merged 1 commit into
containers:mainfrom
nalind:copier-testtarput-chroot

Conversation

@nalind
Copy link
Copy Markdown
Member

@nalind nalind commented May 18, 2026

What type of PR is this?

/kind other

What this PR does / why we need it:

Update the copier.TestTarPut() test to exercise both chroot and non-chroot code paths when they're available.

How to verify it

Updated unit test!

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Update the TestTarPut() test to exercise both chroot and non-chroot code
paths when they're available.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 18, 2026
@packit-as-a-service
Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Copy Markdown
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

I'm going to smash this one through
/lgtm

@TomSweeneyRedHat TomSweeneyRedHat merged commit 8d0d8f9 into containers:main May 22, 2026
40 checks passed
@nalind nalind deleted the copier-testtarput-chroot branch May 26, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants