tests: Normalize json before comparing it.#636
Merged
jnovy merged 1 commit intocontainers:mainfrom Feb 19, 2026
Merged
Conversation
jnovy
requested changes
Feb 18, 2026
The conmon-v3 produces slightly different json. It is still valid, but it cannot be matched with the very same strings as the one produced by the conmon-v2. This commit normalizes the JSON using `jq` before comparing it and as a result, these conmon-v2 tests also pass against conmon-v3. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
Member
Author
|
@jnovy , comments should be addressed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conmon-v3 produces slightly different json. It is still valid, but it cannot be matched with the very same strings as the one produced by the conmon-v2.
This commit normalizes the JSON using
jqbefore comparing it and as a result, these conmon-v2 tests also pass against conmon-v3.