Skip to content

Conversation

@eriksjolund
Copy link
Contributor

This fix will match how it's written elsewhere

$ git grep  "Auto-userns-max-size is the maximum size" main
main:storage/docs/containers-storage.conf.5.md:  Auto-userns-max-size is the maximum size for a user namespace created automatically.
main:storage/storage.conf:# Auto-userns-max-size is the maximum size for a user namespace created automatically.

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
@github-actions github-actions bot added the storage Related to "storage" package label Nov 12, 2025
@Luap99
Copy link
Member

Luap99 commented Nov 12, 2025

If we have a "duplicated" file for freebsd then I am not sure why it would document the userns size at all , there is no things such as user namespaces there AFAIK so it feels confusing to mention such things in the comments.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I am cool merging this but I think here and in the other repos we could really need a proper doc build system where where can have platform specific bits without duplicating entire files. Not just for the config file but the man pages as well of course.

Anyhow that is much larger topic I guess.

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that option seems not to be used in non-Linux.

Either way, this is a clear improvement. Thanks!

@mtrmac mtrmac enabled auto-merge November 12, 2025 19:05
@mtrmac mtrmac merged commit 8e4389e into containers:main Nov 12, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage Related to "storage" package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants