Skip to content

Conversation

@ueno
Copy link
Contributor

@ueno ueno commented Nov 16, 2025

These wrapper files are generated using dlwrap, licensed under "Apache-2.0 OR FSFAP". Given myself is the sole author of the tool, and the generated files do not include any information derived from the original C headers, I'm adding copyright notice of myself.

Fixes: #472

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that is clear from just that sentence that this is FSFAP licensed ,especially for people consuming the full repo. AFAIK we require all our contributions to be under Apache-2.0 like the top level file suggests https://github.com/containers/container-libs/blob/main/image/LICENSE

I bring this up because I am not sure that this is compatible with podman/buildah/skopeo because the CNCF projects have specific rules on what licenses we are allowed to use https://github.com/cncf/foundation/blob/main/policies-guidance/allowed-third-party-license-policy.md#approved-licenses-for-allowlist

The FSFAP does not appear to be allowed and would require an exception which is a slow process so I rather not go that route.
It is your contribution so you do own your copyright and can decide but I think it would be much better if this could be relicensed under Apache-2 like the rest of our code base is.

@Luap99
Copy link
Member

Luap99 commented Nov 17, 2025

cc @containers/podman-maintainers @containers/container-libs-maintainers

@giuseppe
Copy link
Member

it is probably possible to relicense it to Apache-2.0 (and keep the original notice as required), but would be easier if the author just do that so we don't need to guess or ask a lawyer.

@ueno was this done during your your Red Hat working hours? Could you please relicense it to Apache-2.0?

@ueno
Copy link
Contributor Author

ueno commented Nov 17, 2025

I can relicense it as "Apache-2.0 OR FSFAP" or "Apache-2.0 OR Unlicense". Would that work?

@Luap99
Copy link
Member

Luap99 commented Nov 17, 2025

Apache-2.0 OR FSFAP

I think that works.

These wrapper files are generated using dlwrap, licensed under
"Apache-2.0 OR FSFAP". Given myself is the sole author of the tool,
and the generated files do not include any information derived from
the original C headers, I'm adding copyright notice of myself.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
@ueno ueno force-pushed the wip/sequoia-copyright branch from 430ef5e to beaee9b Compare November 18, 2025 05:29
@ueno
Copy link
Contributor Author

ueno commented Nov 18, 2025

Done.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ueno could you, please, also commit the update to https://github.com/ueno/podman-sequoia , so that the two don’t get out of sync and we won’t have to worry about licensing if the interface of podman-sequoia is expanded in the future?

@mtrmac mtrmac merged commit 4654767 into containers:main Nov 18, 2025
24 checks passed
ueno added a commit to ueno/podman-sequoia that referenced this pull request Nov 19, 2025
This propagate the license change of the generated C files from FSFAP
to "Apache-2.0 OR FSFAP". See
containers/container-libs#473 for details.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
ueno added a commit to ueno/podman-sequoia that referenced this pull request Nov 19, 2025
This propagate the license change of the generated C files from FSFAP
to "Apache-2.0 OR FSFAP". See
containers/container-libs#473 for details.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

image Related to "image" package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please clarify copyright holders for https://github.com/containers/container-libs/tree/main/image/signature/internal/sequoia

4 participants