Skip to content

Conversation

@kairosci
Copy link
Contributor

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all commits.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

With `--network=host`, `host.containers.internal` now resolves to `127.0.0.1` (localhost) instead of an external IP address.

Ref: containers/podman#27927

@github-actions github-actions bot added the common Related to "common" package label Jan 20, 2026
podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Jan 20, 2026
@podmanbot
Copy link

✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6646

@packit-as-a-service
Copy link

Packit jobs failed. @containers/packit-build please check.

2 similar comments
@packit-as-a-service
Copy link

Packit jobs failed. @containers/packit-build please check.

@packit-as-a-service
Copy link

Packit jobs failed. @containers/packit-build please check.

@kairosci
Copy link
Contributor Author

Again, there was a race condition error.

@kairosci kairosci requested a review from Luap99 January 20, 2026 20:42
podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Jan 20, 2026
@kairosci kairosci force-pushed the host-containers-internal-localhost branch from 5e14b88 to e1e1e9c Compare January 20, 2026 20:47
podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Jan 20, 2026
@kairosci kairosci force-pushed the host-containers-internal-localhost branch from e1e1e9c to 3eb60ea Compare January 20, 2026 20:50
podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Jan 20, 2026
@kairosci kairosci force-pushed the host-containers-internal-localhost branch from 3eb60ea to 08e9a2b Compare January 21, 2026 10:41
podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Jan 21, 2026
@Luap99
Copy link
Member

Luap99 commented Jan 21, 2026

Can you squash the commits please? fixups in a PR should be squashed for a better commit history.
Also there is a trailing whitespace error.

@kairosci kairosci force-pushed the host-containers-internal-localhost branch from 08e9a2b to 8a766f7 Compare January 21, 2026 13:41
Signed-off-by: Alessio Attilio <attilio.alessio@protonmail.com>
@kairosci kairosci force-pushed the host-containers-internal-localhost branch from 8a766f7 to 38d7ee7 Compare January 21, 2026 13:42
@kairosci
Copy link
Contributor Author

Removed the final space and performed "squash and forced push".

podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Jan 21, 2026
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kairosci
Copy link
Contributor Author

@mheon PTAL

@mheon
Copy link
Member

mheon commented Jan 21, 2026

LGTM

@mheon mheon merged commit 6311ae5 into containers:main Jan 21, 2026
17 checks passed
@kairosci kairosci deleted the host-containers-internal-localhost branch January 21, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to "common" package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants