common: port pkg/config to new configfile package#615
Merged
ashley-cui merged 5 commits intocontainers:mainfrom Feb 4, 2026
Merged
common: port pkg/config to new configfile package#615ashley-cui merged 5 commits intocontainers:mainfrom
ashley-cui merged 5 commits intocontainers:mainfrom
Conversation
github-actions
Bot
added
storage
Member
|
Quick look |
Luap99
force-pushed
the
containers-conf
branch
3 times, most recently
from
dc3ba83 to
c8074b4
Compare
In order to use the new pkg/configfile from storage we must use a newer commit in go.mod to make go mod tidy happy. Without this tidy fails as it cannot lookup the package in the specified version. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
force-pushed
the
containers-conf
branch
from
c8074b4 to
bfadede
Compare
Member
Author
|
Ok marking as ready for review, containers/podman#27997 is a podman test PR which mostly passes test except some minor new error message fixes that will now be needed there. |
Luap99
changed the title
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The toml decoder does not mention the path so we need to wrap it in, without it users won't know which file has the invalid syntax. Also add a some context on module open error so users know the issue is with the module not the main config files. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Print the file path on debug level and the full struct with trace level in order to allow easier debugging on config loading problems. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
First actually ensure to reset the log level back to info. Then because the file loading now logs the file path on debug level we no longer can match for empty output. To check that there is no error in the default file ensure there is no "Failed to decode the keys" line. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
force-pushed
the
containers-conf
branch
from
ba3c142 to
4b84232
Compare
Contributor
|
Done with review. I think it's great work! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #611