Merged
Conversation
|
Packit jobs failed. @containers/packit-build please check. |
Member
|
@mtrmac anything more you want to do on this PR or can we merge it? |
This is more consistent with the other graph drivers. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This avoids the awkward creation of a Driver object just to pass that around. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Don't overwrite the caller's StorageOpt map; instead, handle that at parse time. To implement defaults in parseStorageOpt, we need to call it even if opts is nil or StorageOpt is nil. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Don't have it in two places. So that we fail without affecting the file system, move the parseStorageOpt call earlier. Unknown options when creating read-only layers now cause failures (but this is all hypothetical anyway, because c/storage does not allow external callers to pass StorageOpt when creating read-only layers.) Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... so that we don't change the filesystem on error. Also move the "opts == nil" handling, to be consistent with overlay. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Contributor
Author
|
@giuseppe I think this is ready for merging. I have only rebased it now, to make sure it didn’t break in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily fix overlay so that it doesn’t modify callers’
StorageOpt.Also report errors earlier, remove duplication, and other minor cleanups. See individual commit messages for details.
Motivated by #719; Cc: @akhilsaivenkata .