common: mount config dir to /etc/containers for machine#779
common: mount config dir to /etc/containers for machine#779Luap99 wants to merge 1 commit intocontainers:mainfrom
Conversation
Luap99
added
the
podman 6
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Just a drive-by: The implementation looks plausible, but I have really no opinion on whether this should happen, which is a much more important question.
| return MachineConfig{}, err | ||
| } | ||
| // Mount the (host side) user config dir to the machine /etc/containers | ||
| // This is done per request from PD who like to be able to persist config |
There was a problem hiding this comment.
We may forget, over time, what PD stands for.
There was a problem hiding this comment.
I agree with @mtrmac, this can be improved. It's not a podman desktop issue but rather a general improvement of UX for podman machine users.
|
LGTM |
|
Marking as draft as I need to do some tests in podman. I think one issue that machine mounts are not used on WSL. So I am not sure what best to do there? Also I believe this first requires the packaging changes from the config file rework to move all files to /usr. Otherwise we end up over mounting important files such as policy.json which will make podman pull fail. |
Yes |
Luap99
force-pushed
the
machine-config-mount
branch
from
837c164 to
3bfaf1a
Compare
Luap99
force-pushed
the
machine-config-mount
branch
2 times, most recently
from
41017d0 to
1525c28
Compare
Matches changes from containers/container-libs#779 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Matches changes from containers/container-libs#779 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This is wanted to share the same configs between host and machine and make edits easier. It also solves the problem of which config is read where as now there will only be one file. Fixes: https://redhat.atlassian.net/browse/RUN-3847 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
force-pushed
the
machine-config-mount
branch
from
1525c28 to
8488036
Compare
Matches changes from containers/container-libs#779 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
Ok I think this is basically ready, I would like to see some reviews on containers/podman#28573 before merging this to ensure there are no major objections there. Because once this PR here is merged we need the podman one to adapt properly. |
5 participants
This is wanted to share the same configs between host and machine and make edits easier. It also solves the problem of which config is read where as now there will only be one file.
Fixes: https://redhat.atlassian.net/browse/RUN-3847