common/pkg/parse: switch away from runc/libct/devices#781
common/pkg/parse: switch away from runc/libct/devices#781mtrmac merged 1 commit intocontainers:mainfrom
Conversation
The github.com/opencontainers/runc/libcontainer/devices package was _mostly_ moved to github.com/opencontainers/cgroups/devices/config (see e.g. commit commit 9ac03e6). The rest of runc/libcontainer/devices now lives in moby/sys/devices (see moby/sys#212). The package is deprecated since runc v1.5 and will be removed from runc v1.6. Let's switch now to not worry later. PS vendor/github.com/opencontainers/runc/libcontainer/devices is not removed because it is still being used by common/pkg/parse. This is addressed by containers/container-libs#781 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
Packit jobs failed. @containers/packit-build please check. |
1 similar comment
|
Packit jobs failed. @containers/packit-build please check. |
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks! Please re-format.
@TomSweeneyRedHat After this PR, we import only ~7 lines of code from the runc repo in to c/common. Would it significantly help our CVE workload if we got rid of the dependency?
There is no direct dep in podman either, there are a few in buildah but I guess one could be able to remove them as well and then that would certainly help no having to audit each new runc CVE in the codebase. |
The github.com/opencontainers/runc/libcontainer/devices package was _mostly_ moved to github.com/opencontainers/cgroups/devices/config for runc v1.3. The rest of runc/libcontainer/devices now lives in moby/sys/devices (see moby/sys#212). The package is deprecated since runc v1.5 and will be removed from runc v1.6. Let's switch now to not worry later. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
Thanks! |
3 participants
The github.com/opencontainers/runc/libcontainer/devices package was mostly moved to github.com/opencontainers/cgroups/devices/config for runc v1.3.
The rest of runc/libcontainer/devices now lives in moby/sys/devices (see moby/sys#212). The package is deprecated since runc v1.5 and will be removed from runc v1.6.
Let's switch now to not worry later.