Skip to content

Bump to c/storage v1.63.0 in c/image, c/image to v5.40#858

Merged
mtrmac merged 2 commits into
containers:mainfrom
TomSweeneyRedHat:dev/tsweeney/podman-6.0
May 20, 2026
Merged

Bump to c/storage v1.63.0 in c/image, c/image to v5.40#858
mtrmac merged 2 commits into
containers:mainfrom
TomSweeneyRedHat:dev/tsweeney/podman-6.0

Conversation

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

Bump c/storage to v1.63.0 in c/image, then bump c/image to v5.40.0

I'll follow up with a dev bump everywhere at the end of this process.

@github-actions github-actions Bot added the image Related to "image" package label May 20, 2026
Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must update the go.mod from common as well, we require that the modules requirements are in sync.

Copy link
Copy Markdown
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomSweeneyRedHat go work sync && go work vendor && make vendor or repeat make vendor until stability.

@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/podman-6.0 branch from fe72023 to ec94009 Compare May 20, 2026 14:16
@github-actions github-actions Bot added the common Related to "common" package label May 20, 2026
@mtrmac
Copy link
Copy Markdown
Contributor

mtrmac commented May 20, 2026

@TomSweeneyRedHat (one more?) make vendor please.

@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/podman-6.0 branch from ec94009 to 711f1a3 Compare May 20, 2026 17:36
@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

There's no Vendor section in the Makefile. I went with go mod {tidy|vendor|verify} again. For the first time, it created a vendor directory in Image; I've included that. It also created a common/vendor prior; I'd not included it, but decided to now. Now it looks like there's more red....

@mtrmac
Copy link
Copy Markdown
Contributor

mtrmac commented May 20, 2026

There's no Vendor section in the Makefile

There’s one in the top level Makefile, not in image/Makefile.

@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

DOH! I tried make vendor in c/storage, not so good there. It works better in the top level directory, trying again.

@mtrmac
Copy link
Copy Markdown
Contributor

mtrmac commented May 20, 2026

@TomSweeneyRedHat #861 seems to pass.

Bump c/storage to v1.63.0 in c/image and c/common

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
Bump c/image to v5.40 for Podman v6.0

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/podman-6.0 branch from b36fe51 to 3c2fa91 Compare May 20, 2026 18:48
@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

@mtrmac thanks for the other PR, that was very helpful. The big issue I had was doing make vedor in each project's subdirectory instead of up top. I've changed that, and removed the vendorerd directories. Fingers crossed.

Copy link
Copy Markdown
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TomSweeneyRedHat when creating the GitHub release, please highlight that config file lookup behavior has changed and users should read containers-config(5).

@mtrmac mtrmac merged commit 9f17ede into containers:main May 20, 2026
24 checks passed
@TomSweeneyRedHat
Copy link
Copy Markdown
Member Author

@mtrmac I don't think we'll be making a release, only tags. @Luap99 thoughts?

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented May 21, 2026

We will need a release for common so packit works. Long term we likely want an automation to create the release with a right tarball for debian packing #485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to "common" package image Related to "image" package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants