Skip to content

Misc. code cleanups#872

Merged
giuseppe merged 6 commits into
containers:mainfrom
mtrmac:modernize
May 26, 2026
Merged

Misc. code cleanups#872
giuseppe merged 6 commits into
containers:mainfrom
mtrmac:modernize

Conversation

@mtrmac
Copy link
Copy Markdown
Contributor

@mtrmac mtrmac commented May 25, 2026

See individual commit messages.

@github-actions github-actions Bot added storage Related to "storage" package common Related to "common" package image Related to "image" package labels May 25, 2026
mtrmac added 6 commits May 25, 2026 18:55
Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change (test) behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
There's a slight risk this might start reporting errors
that were previously silently ignored - hopefully only in cases
of wrong parsing implementation.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Changes the reported error type, but we continue to
make no promises in that respect - especially
because the used mechanism differs based on build tags.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Avoid IDE noise about build failures on Windows.

Should not change (test) behavior in practice.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @giuseppe

Copy link
Copy Markdown
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit db27e45 into containers:main May 26, 2026
37 checks passed
@mtrmac mtrmac deleted the modernize branch May 26, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to "common" package image Related to "image" package storage Related to "storage" package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants