krun: fix error return

[giuseppe]

terminate the current container process instead of returning.

Closes: #1958

[gemini-code-assist]

Summary of Changes

Hello @giuseppe, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the error handling within the krun handler by ensuring that critical failures, such as issues with virtio GPU enablement or starting the krun process, lead to immediate program termination with informative error messages. This change improves the robustness and debuggability of the krun component by preventing silent failures or incorrect error code propagation.

Highlights

• Improved Error Handling: Replaced direct error returns with calls to error(EXIT_FAILURE, ...) for critical failures in libkrun_exec, ensuring immediate termination and clear error messages when enabling virtio GPU.
• Corrected Krun Start Logic: Fixed the return value from krun_start_enter to correctly propagate success/failure, and added error termination for failure cases, preventing incorrect error code propagation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully modifies the error handling within the libkrun_exec function in src/libcrun/handlers/krun.c. Previously, failures related to enabling virtio GPU or starting krun would result in libkrun_exec returning an error code. The updated code now terminates the crun process by calling error(EXIT_FAILURE, ...), which aligns with the pull request description to "terminate the current container process instead of returning." This change correctly implements the desired behavior of exiting the runtime process upon these specific failures.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[slp]

LGTM, thanks!