container: handle libcrun_container_run_internal error correctly

[eriksjolund]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @eriksjolund, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the error handling within the container creation process by ensuring that error codes are correctly extracted and that associated error resources are properly released. This change specifically addresses scenarios where internal container run operations fail, leading to more robust error reporting and improved resource management within the libcrun library.

Highlights

• Improved Error Code Extraction: The error handling logic in libcrun_container_create now explicitly retrieves the error code using crun_error_get_errno for more accurate reporting, rather than directly accessing a status field.
• Proper Error Resource Release: A call to crun_error_release has been added to ensure that the error object is properly freed after its message and code have been processed, preventing potential memory leaks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request fixes a memory leak in libcrun_container_create by releasing an error object that was previously leaked. While this is a valid fix for the leak, my review points out that this approach changes the public API by consuming the error details instead of propagating them to the caller. I've suggested an alternative that maintains API consistency by letting the caller handle the error object, which is the standard pattern in this library.

[gemini-code-assist]

This change correctly fixes a memory leak by releasing the error object. However, by consuming the error here (logging and releasing), it prevents the caller of libcrun_container_create from inspecting the error details. This behavior is inconsistent with other public API functions in this library which typically propagate the libcrun_error_t object to the caller.

To maintain a consistent API, it would be better to not handle the error here. Instead, this function should perform its specific cleanup and let the caller decide whether to log the error and when to release it. This allows for more flexible error handling by the library's users.

I suggest removing these lines to allow the error to be propagated.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[giuseppe]

LGTM