container: do not release returned error

[giuseppe]

Closes: #1980

[gemini-code-assist]

Summary of Changes

Hello @giuseppe, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an error handling refinement in the container_init function. It removes a redundant error object release, ensuring that error objects are correctly managed by the caller when propagated. This change enhances the robustness of error handling by preventing premature deallocation of error resources.

Highlights

• Error Handling: Prevented the premature release of an error object (err) within the container_init function when an error is returned. This ensures that the responsibility for releasing the error object lies with the calling function, avoiding potential double-free issues or use-after-free scenarios.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/libcrun/container.c
  • Removed the crun_error_release(err) call before returning ret when sync_socket_write_error fails, ensuring the error object's lifecycle is managed by the caller.

Activity

• The pull request was opened by giuseppe to address issue container_init() returns a negative number but no error has been created #1980, which likely pointed out the error handling discrepancy.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug where error messages were not being propagated from the container_init function. By removing the premature release of the error object, you ensure that the error can be handled and logged by the caller, which resolves the issue of silent failures. This is a good improvement to error handling.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[eriksjolund]

      if (sync_socket_write_error (sync_socket, err) < 0)
        return ret;

      return ret;

is more or less the same as

      sync_socket_write_error (sync_socket, err);
      return ret;

(I don't know what is best)

[giuseppe]

we have some special handling for the entrypoint function to avoid printing the error twice.

I'll fix it to return > 0 to signal retcode != 0 without an error

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[kolyshkin]

@eriksjolund can you take another look?

[eriksjolund]

LGTM