fix: correct UID/GID mapping buffer offset for multi-line mappings#2075
Merged
giuseppe merged 1 commit intocontainers:mainfrom Apr 24, 2026
Merged
Conversation
format_default_id_mapping() had 'written += written' instead of 'written += ret' causing the buffer offset to stay at 0 when container_id > 0. This overwrites the first mapping line. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in the format_default_id_mapping function within src/libcrun/utils.c where the written byte count was incorrectly doubled instead of being incremented by the number of bytes actually written. To verify the fix and prevent regressions, a new test case test_format_default_id_mapping has been added to the test suite, and the total test counts have been updated accordingly. I have no feedback to provide.
|
TMT tests failed. @containers/packit-build please check. |
Member
Author
|
@jnovy PTAL |
Contributor
|
Nice catch of the LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_default_id_mapping() had 'written += written' instead of 'written += ret' causing the buffer offset to stay at 0 when container_id > 0. This overwrites the first mapping line.