Skip to content

Conversation

@jakecorrenti
Copy link
Member

Due to a docs bug in vfkit, we have incidentally diverged from vfkit default behavior by using tcp as the default. Now that the argument supports none://, that should be the default instead.

Fixes: #53

Due to a docs bug in vfkit, we have incidentally diverged from vfkit
default behavior by using tcp as the default. Now that the argument
supports none://, that should be the default instead.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
@jakecorrenti jakecorrenti changed the title WIP: src: docs: Change --restful-uri default src: docs: Change --restful-uri default Aug 29, 2025
@jakecorrenti jakecorrenti marked this pull request as ready for review August 29, 2025 17:28
@jakecorrenti
Copy link
Member Author

This is technically a breaking change, but we still aren't v1.0.0 yet so it doesn't break SEMVER rules

@jakecorrenti jakecorrenti changed the title src: docs: Change --restful-uri default status: docs: Change --restful-uri default Aug 29, 2025
@nirs
Copy link
Contributor

nirs commented Aug 29, 2025

@jakecorrenti did you test this with podman? I think it does not use the default. minikube uses now none://.

@jakecorrenti
Copy link
Member Author

jakecorrenti commented Aug 29, 2025

@jakecorrenti did you test this with podman? I think it does not use the default. minikube uses now none://.

Yes. Podman overrides it with --restful-uri tcp://... in their cmd

Copy link
Collaborator

@slp slp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@slp slp merged commit 6a69880 into containers:main Sep 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change default restful-uri to none://

3 participants