Skip to content

Conversation

@blublinsky
Copy link
Contributor

This PR is adding supports for getting information about kubernetes cluster nodes

@manusa
Copy link
Member

manusa commented Oct 21, 2025

Hi, Boris.

Thanks for contributing!

As discussed internally, at the moment, we're trying to minimize the number of tools the MCP server exposes to avoid problems with smaller models or taking up too much of the token context window budget.

In this PR you're introducing multiple CRUD tools that the LLM should not need since it should be able to leverage the generic resource tools.
Similarly, for events, there is specific tooling for event retrieval that should not be necessary. In case there is a specific prompt+model combination that doesn't work with the current tooling, but works with the one proposed, we should evaluate how to deal with the specific case.

IMHO the only tool that brings something new and would be impossible to replace with current tooling is the one to retrieve the node logs. We should only keep this one.

@Cali0707 @matzew @mrunalp thoughts?

@Cali0707
Copy link
Collaborator

IMHO the only tool that brings something new and would be impossible to replace with current tooling is the one to retrieve the node logs. We should only keep this one.

+1 here

@blublinsky
Copy link
Contributor Author

removed all the tools except log

@manusa manusa requested review from Cali0707, manusa and matzew October 22, 2025 13:25
@matzew
Copy link
Collaborator

matzew commented Oct 22, 2025

@blublinsky thanks for the PR and addressing our comments
I will test it before I merged

@blublinsky blublinsky force-pushed the nodes branch 2 times, most recently from e6307ae to ff11649 Compare October 22, 2025 15:19
matzew and others added 2 commits October 22, 2025 16:20
add support for nodes logs

Signed-off-by: blublinsky <blublinsky@hotmail.com>
Signed-off-by: blublinsky <blublinsky@hotmail.com>
@matzew
Copy link
Collaborator

matzew commented Oct 23, 2025

I tested w/ the kind-control-plane node on my machine, and changed the log-path to alternatives.log, and got results

@matzew matzew merged commit 3072d19 into containers:main Oct 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants