-
Notifications
You must be signed in to change notification settings - Fork 167
add support for nodes query #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+376
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| package kubernetes | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| ) | ||
|
|
||
| func (k *Kubernetes) NodeLog(ctx context.Context, name string, logPath string, tail int64) (string, error) { | ||
| // Use the node proxy API to access logs from the kubelet | ||
| // Common log paths: | ||
| // - /var/log/kubelet.log - kubelet logs | ||
| // - /var/log/kube-proxy.log - kube-proxy logs | ||
| // - /var/log/containers/ - container logs | ||
|
|
||
| if logPath == "" { | ||
| logPath = "kubelet.log" | ||
| } | ||
|
|
||
| // Build the URL for the node proxy logs endpoint | ||
| url := []string{"api", "v1", "nodes", name, "proxy", "logs", logPath} | ||
|
|
||
| // Query parameters for tail | ||
| params := make(map[string]string) | ||
| if tail > 0 { | ||
| params["tailLines"] = fmt.Sprintf("%d", tail) | ||
| } | ||
|
|
||
| req := k.manager.discoveryClient.RESTClient(). | ||
| Get(). | ||
| AbsPath(url...) | ||
|
|
||
| // Add tail parameter if specified | ||
| for key, value := range params { | ||
| req.Param(key, value) | ||
| } | ||
|
|
||
| result := req.Do(ctx) | ||
| if result.Error() != nil { | ||
| return "", fmt.Errorf("failed to get node logs: %w", result.Error()) | ||
| } | ||
|
|
||
| rawData, err := result.Raw() | ||
| if err != nil { | ||
| return "", fmt.Errorf("failed to read node log response: %w", err) | ||
| } | ||
|
|
||
| return string(rawData), nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| package mcp | ||
|
|
||
| import ( | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/mark3labs/mcp-go/mcp" | ||
| corev1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| ) | ||
|
|
||
| func TestNodeLog(t *testing.T) { | ||
| testCase(t, func(c *mcpContext) { | ||
| c.withEnvTest() | ||
|
|
||
| // Create test node | ||
| kubernetesAdmin := c.newKubernetesClient() | ||
| node := &corev1.Node{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "test-node-log", | ||
| }, | ||
| Status: corev1.NodeStatus{ | ||
| Addresses: []corev1.NodeAddress{ | ||
| {Type: corev1.NodeInternalIP, Address: "192.168.1.10"}, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| _, _ = kubernetesAdmin.CoreV1().Nodes().Create(c.ctx, node, metav1.CreateOptions{}) | ||
|
|
||
| // Test node_log tool | ||
| toolResult, err := c.callTool("node_log", map[string]interface{}{ | ||
| "name": "test-node-log", | ||
| }) | ||
|
|
||
| t.Run("node_log returns successfully or with expected error", func(t *testing.T) { | ||
| if err != nil { | ||
| t.Fatalf("call tool failed: %v", err) | ||
| } | ||
| // Node logs might not be available in test environment | ||
| // We just check that the tool call completes | ||
| if toolResult.IsError { | ||
| content := toolResult.Content[0].(mcp.TextContent).Text | ||
| // Expected error messages in test environment | ||
| if !strings.Contains(content, "failed to get node logs") && | ||
| !strings.Contains(content, "not logged any message yet") { | ||
| t.Logf("tool returned error (expected in test environment): %v", content) | ||
| } | ||
| } | ||
| }) | ||
| }) | ||
| } | ||
|
|
||
| func TestNodeLogMissingArguments(t *testing.T) { | ||
| testCase(t, func(c *mcpContext) { | ||
| c.withEnvTest() | ||
|
|
||
| t.Run("node_log requires name", func(t *testing.T) { | ||
| toolResult, err := c.callTool("node_log", map[string]interface{}{}) | ||
|
|
||
| if err == nil && !toolResult.IsError { | ||
| t.Fatal("expected error when name is missing") | ||
| } | ||
| }) | ||
| }) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.