feat(kiali): Consolidate kiali tools from 20 to 6 #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljesusg
force-pushed
the
consolidate_kiali_tools
branch
from
f696ba8 to
ae3cf2f
Compare
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
aljesusg
force-pushed
the
consolidate_kiali_tools
branch
from
ae3cf2f to
bbc1144
Compare
This was referenced Nov 24, 2025
aljesusg
changed the title
Contributor
Author
|
@manusa I did the reduction of tools from 20 to 6. I tested then with gevals and it's working with all use cases. |
This was referenced Nov 24, 2025
manusa
requested changes
Nov 24, 2025
Member
manusa
left a comment
manusa
left a comment
There was a problem hiding this comment.
Overall looks good, thanks!
I did find a few issues that should be addressed, see inlined comments.
manusa
reviewed
Nov 24, 2025
| // - health: /api/clusters/health (optionally filtered by namespaces and queryParams) | ||
| // - status(mesh):/api/mesh/graph | ||
| // - namespaces: /api/namespaces | ||
| func (k *Kiali) GetMeshGraph(ctx context.Context, namespaces []string, queryParams map[string]string) (string, error) { |
Member
There was a problem hiding this comment.
Note, this is a good candidate to try out MCP progress notifications (Not in this PR)
aljesusg
force-pushed
the
consolidate_kiali_tools
branch
2 times, most recently
from
2bfe9ae to
9387960
Compare
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com> Co-authored-by: Marc Nuri <marc@marcnuri.com>
aljesusg
force-pushed
the
consolidate_kiali_tools
branch
from
9387960 to
019f272
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate Kiali Tools reduncy the number of tools from 20 to 6