pkg/kvp: various fixes#36
Merged
openshift-merge-robot merged 8 commits intocontainers:mainfrom Jun 28, 2023
bgilbert:kvp
Merged
pkg/kvp: various fixes#36openshift-merge-robot merged 8 commits intocontainers:mainfrom bgilbert:kvp
openshift-merge-robot merged 8 commits intocontainers:mainfrom
bgilbert:kvp
Conversation
Signed-off-by: Benjamin Gilbert <bgilbert@redhat.com>
Signed-off-by: Benjamin Gilbert <bgilbert@redhat.com>
Represent the values in octal to avoid setting the modes to garbage. Also, create parent directories with mode 755, since that matches what hv_kvp_daemon does, and world-writable directories in system paths are potentially dangerous. Signed-off-by: Benjamin Gilbert <bgilbert@redhat.com>
The contents of any existing pool file are presumably stale, so it doesn't make sense to fail if one exists (after we've potentially already written out some of the other pools). Also fixes a stray format escape passed to a function that doesn't respect them. Signed-off-by: Benjamin Gilbert <bgilbert@redhat.com>
Ignition has a use for it. Signed-off-by: Benjamin Gilbert <bgilbert@redhat.com>
The leftOvers return value doesn't actually do what it says, and isn't used by Ignition, which is the only caller. Remove it. Signed-off-by: Benjamin Gilbert <bgilbert@redhat.com>
In read(2), also retry on EINTR. In poll(2), only retry on EINTR; EFAULT and ENOMEM are also fatal. Signed-off-by: Benjamin Gilbert <bgilbert@redhat.com>
The host can send us other message types, which we aren't prepared to handle. Rather than returning a bogus response or letting the protocol desynchronize, just return a failure in this case. Signed-off-by: Benjamin Gilbert <bgilbert@redhat.com>
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, bgilbert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some things used by Ignition, and some other things I noticed along the way. See individual commits for details.
cc @baude