Add API for Disk Resize#66
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
once #67 merges, i will write an integration test with the current code and then update to the suggested code. that will make me feel more comfy with the change |
|
Yes, we want to replace this: The new API seems to fit. |
|
LGTM |
Not yet, although there is an API call we can get it from here: |
|
ill add the api now |
|
LGTM other than the go.sum conflict |
Add disk resize api for pkg/hypvctl that takes a disk path and a strongly typed new size. No error protection for invalid disk resizes (like trying to descrease the size of a disk). Fixes: containers#54 Signed-off-by: Brent Baude <bbaude@redhat.com>
|
|
||
| // PowerShellCommand is a wrapper to run something in powershell. It takes a command and args. | ||
| // And it returns stdout as a string | ||
| func PowerShellCommand(commandName string, args []string) (string, error) { |
There was a problem hiding this comment.
No, but a the test suite gets filled out, I'm certain it will be.
|
/lgtm |
Add disk resize api for pkg/hypvctl that takes a disk path and a strongly typed new size. No error protection for invalid disk resizes (like trying to descrease the size of a disk).
Fixes: #54