Add krun_add_disk() method#217
Merged
slp merged 5 commits intocontainers:mainfrom Sep 19, 2024
alyssarosenzweig:disk2
Merged
Conversation
alyssarosenzweig
requested review from
mtjhrc,
slp and
tylerfanelli
as code owners
tylerfanelli
reviewed
Sep 9, 2024
slp
requested changes
Sep 11, 2024
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Contributor
Author
|
Per @slp's suggestion I have reworked this.
This retains b/w compat without introducing too much silliness. Hopefully we're all happy with this now 😄 |
This generalizes over krun_set_{root,data}_disk(). Notably:
* It allows arbitrarily many disk images.
* It allows mounting disks read-only.
* It does not assume specific root/data semantics.
* It allows setting labels.
To implement, we refactor a bit the existing handling. The set_*_disk
methods are deprecated due to the above issues, and will be removed in a
future major version. For now both APIs are supported but are mutually
exclusive.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
slp
approved these changes
Sep 19, 2024
slp
pushed a commit
to AsahiLinux/muvm
that referenced
this pull request
Sep 26, 2024
This adds a mechanism for automatically managing the FEX rootfs, mounting and overlayfs'ing the relevant squashfs files from the host (as many as desired). Depends on: * libkrun containers/libkrun#217 * libkrunfw containers/libkrunfw#65 Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to mount systemwide squashfs images which Asahi will use for FEX.