virtio/fs/linux: Fix xattrs on symlinks#224
Merged
slp merged 1 commit intocontainers:mainfrom Oct 16, 2024
Merged
Conversation
The f*attr library of functions only works on files opened normally. Symlinks can only be opened with O_PATH, but that doesn't support xattr operations. So, to handle symlinks, we need to use the l*attr family of functions directly on the pathname. Thankfully, this does still work via /proc/self/fd/* for fds opened with O_PATH, so we can still do fd-relative operations (l*attr on such a path resolves the magic symlink and operates on the symlink that is actually opened as that fd). Signed-off-by: Asahi Lina <lina@asahilina.net>
hoshinolina
requested review from
mtjhrc,
slp and
tylerfanelli
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The f*attr library of functions only works on files opened normally. Symlinks can only be opened with O_PATH, but that doesn't support xattr operations. So, to handle symlinks, we need to use the l*attr family of functions directly on the pathname.
Thankfully, this does still work via /proc/self/fd/* for fds opened with O_PATH, so we can still do fd-relative operations (l*attr on such a path resolves the magic symlink and operates on the symlink that is actually opened as that fd).
This fixes
ls: bin: Too many levels of symbolic linkserrors in the guest when SELinux attributes are in use.