Update SEV deps to latest versions#238
Merged
tylerfanelli merged 3 commits intomainfrom Nov 13, 2024
Merged
Conversation
Signed-off-by: Sergio Lopez <slp@redhat.com>
This required minor changes in amdsev. Signed-off-by: Sergio Lopez <slp@redhat.com>
Signed-off-by: Sergio Lopez <slp@redhat.com>
Collaborator
Author
|
@tylerfanelli PTAL |
tylerfanelli
approved these changes
Nov 13, 2024
Member
tylerfanelli
left a comment
tylerfanelli
left a comment
There was a problem hiding this comment.
LGTM, but the sev crate's 4.0.0 will not run on upstream kernels. We're looking to update to 5.0.0 now that 6.11 brought "stable" support. Perhaps we should wait to update libkrun until sev-5.0.0 is up? Shouldn't be much longer
Collaborator
Author
We need it to be in sync with the status of the packages in Fedora to be able to produce new releases. We can do another omnibus updates once 5.0.0 is released. |
Member
|
SGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.