init: allow running the user-provided init as pid 1 (fix #223) #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes definitely. In fact I have also ran into this limitation and I was already thinking we should implement a mechanism like this eventually. Thanks for working on it! |
valpackett
force-pushed
the
val/pqqnnpowvoqt
branch
from
bf2344c to
128a02a
Compare
valpackett
requested review from
MatiasVara,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
Some init systems like systemd absolutely need to run as PID 1. Add an environment variable to allow doing so at the cost of the return code feature. Signed-off-by: Val Packett <val@invisiblethingslab.com>
valpackett
force-pushed
the
val/pqqnnpowvoqt
branch
from
128a02a to
67408cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some init systems like systemd absolutely need to run as PID 1. Add an environment variable to allow doing so at the cost of the exit code feature.
Yes, this is kinda in the direction of "not-so-micro" VMs, but we wanted to try a tiny minimal systemd setup for our own project where we need to run user-configurable background services (like VPN clients) for desktop apps. #223 mentions the systemd-in-a-container use case for k8s stuff. So hopefully this would be acceptable? (after polishing it a bit more: I guess it should be configurable from the JSON file as well..)