Fix cargo feature propagation

[nohajc]

I tried to actually import libkrun as a Rust dependency (based on 44312fd) and it revealed feature propagation to sub-crates is broken.

So, if I have this in Cargo.toml, it won't enable the corresponding features in src/{devices,vmm} for example.

libkrun = { git = "https://github.com/containers/libkrun", features = [
    "blk",
    "net",
] }

[slp]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates the feature definitions in src/libkrun/Cargo.toml and src/vmm/Cargo.toml to ensure proper propagation to sub-crates such as vmm, devices, and arch. A review comment suggests extending this propagation to the aws-nitro feature for consistency with the other updated features.

[jakecorrenti]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates feature propagation across the workspace's Cargo.toml files, ensuring that top-level features correctly enable corresponding functionality in sub-crates like vmm and devices. A critical issue was identified in src/vmm/Cargo.toml where referencing the target-specific cpuid dependency in the global features table will cause build failures on non-x86_64 platforms.

[gemini-code-assist]

Referencing cpuid/tdx in the global features table will cause build failures on non-x86_64 platforms (such as aarch64 or macOS). This is because the cpuid dependency is target-specific (defined under [target.'cfg(target_arch = "x86_64")'.dependencies] at line 49), and Cargo requires that any dependency referenced in a feature list using the pkg/feat syntax must be present for all targets.

To resolve this while maintaining feature propagation, you should consider making cpuid an optional dependency and using the weak dependency syntax cpuid?/tdx. Note that if cpuid is required for other non-TDX functionality on x86_64, you will need to ensure it remains enabled for those cases.

[nohajc]

Isn't TDX only available on Intel anyway?

[nohajc]

If needed, we can move cpuid to unconditional dependencies because the crate code is gated to x86_64 already.

[slp]

LGTM, thanks!